Evolinx/packagekit
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pk-offline-update: Fix crash due to invalid g_auto declaration in switch / case

Browse Source 
'case PK_PROGRESS_TYPE_PERCENTAGE' is just a label and doesn't offer
any scope as such. So, 'tmp_perc' auto variable will be allocated in
the stack, but will not be initialized to 'NULL' for 'case:'
statements other than 'PK_PROGRESS_TYPE_PERCENTAGE', causing GLib to
consider the 'tmp_perc' garbage value as a valid memory address
allocated via 'g_malloc()', triggering an invalid 'free()' causing the
crash.

Rather than adding a scope '{}' within 'case', and causing a huge
noise in git diff, we just move the declaration to an upper scope.
This commit is contained in:
sid 2024-03-22 09:52:13 +00:00 committed by Matthias Klumpp
parent 00e82be060
commit 3605809957
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
client/pk-offline-update.c
View File

@ -113,6 +113,7 @@ pk_offline_update_progress_cb (PkProgress *progress,
PkStatusEnum status;
gint percentage;
g_autofree gchar *msg = NULL;
g_autofree gchar *tmp_perc = NULL;
g_autoptr(PkPackage) pkg = NULL;
switch (type) {
@ -145,8 +146,6 @@ pk_offline_update_progress_cb (PkProgress *progress,
pk_package_get_data (pkg));
break;
case PK_PROGRESS_TYPE_PERCENTAGE:
g_autofree gchar *tmp_perc = NULL;
g_object_get (progress, "percentage", &percentage, NULL);
if (percentage < 0)
return;