From 5476e9948af279bdcac7e66ea5f3a79990a2365e Mon Sep 17 00:00:00 2001
From: Richard Hughes <richard@hughsie.com>
Date: Fri, 31 Aug 2007 01:52:23 +0100
Subject: [PATCH] remove a memory leak, and optimise the storage of the ident
 structure on sparse data

---
 libpackagekit/pk-package-id.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/libpackagekit/pk-package-id.c b/libpackagekit/pk-package-id.c
index 8356d6883..275173820 100644
--- a/libpackagekit/pk-package-id.c
+++ b/libpackagekit/pk-package-id.c
@@ -69,7 +69,6 @@ pk_package_id_split (const gchar *package_id)
 	}
 
 	/* name has to be valid */
-	sections = g_strsplit (package_id, ";", 0);
 	if (strlen (sections[0]) == 0) {
 		pk_warning ("Package ident package is empty");
 		goto out;
@@ -117,10 +116,18 @@ pk_package_id_new_from_string (const gchar *package_id)
 
 	/* create new object */
 	ident = pk_package_id_new ();
-	ident->name = g_strdup (sections[0]);
-	ident->version = g_strdup (sections[1]);
-	ident->arch = g_strdup (sections[2]);
-	ident->data = g_strdup (sections[3]);
+	if (strlen (sections[0]) > 0) {
+		ident->name = g_strdup (sections[0]);
+	}
+	if (strlen (sections[1]) > 0) {
+		ident->version = g_strdup (sections[1]);
+	}
+	if (strlen (sections[2]) > 0) {
+		ident->arch = g_strdup (sections[2]);
+	}
+	if (strlen (sections[3]) > 0) {
+		ident->data = g_strdup (sections[3]);
+	}
 	g_strfreev (sections);
 	return ident;
 }