From 85f5d4af5329997a4a387145c6f967b8ef7afb87 Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Mon, 22 Jul 2024 12:20:16 +0200 Subject: [PATCH] pk-client: Fix runtime warning when backend does not support role The daemon returns "op not supported by the backend" as part of the method call response, but this response can be received after the "Destroy" signal, which causes infinite wait for the transaction end and runtime warnings about NULL error being passed to the g_task_return_error() on the client side. This is a regression from commit https://github.com/PackageKit/PackageKit/commit/44215db95d9cfda23045d9a9b97175519f473eb2 --- lib/packagekit-glib2/pk-client.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/packagekit-glib2/pk-client.c b/lib/packagekit-glib2/pk-client.c index 735c718cb..3cbb0d859 100644 --- a/lib/packagekit-glib2/pk-client.c +++ b/lib/packagekit-glib2/pk-client.c @@ -1616,11 +1616,11 @@ pk_client_signal_cb (GDBusProxy *proxy, if (g_strcmp0 (signal_name, "Destroy") == 0) { g_autoptr(GError) local_error = NULL; - if (state->waiting_for_finished) + if (state->waiting_for_finished) { local_error = g_error_new_literal (PK_CLIENT_ERROR, PK_CLIENT_ERROR_FAILED, "PackageKit transaction disappeared"); - - pk_client_state_finish (state, g_steal_pointer (&local_error)); + pk_client_state_finish (state, g_steal_pointer (&local_error)); + } return; } }