Evolinx/packagekit
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

transaction id is now a dbus path

Browse Source
This commit is contained in:
Richard Hughes 2008-04-06 13:59:28 +01:00
parent 7cc0679470
commit e101e83e28
2 changed files with 7 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/spec/pk-concepts.xml
View File

@ -519,7 +519,7 @@
</para>
<para>
The <literal>transaction_id</literal> must be of the format
<literal>job;identifier;data</literal> where the daemon controls
<literal>/job_identifier_data</literal> where the daemon controls
all parameters.
<literal>job</literal> is a monotonically updating number and is
retained over reboots.
@ -530,7 +530,7 @@
for any other purpose.
It is designed to make the life of a backend writer a little bit easier.
An example <literal>transaction_id</literal> would be
<literal>45;dafeca;checkpoint32</literal>
<literal>/45_dafeca_checkpoint32</literal>
</para>
</sect1>

38
src/pk-transaction-id.c
View File

@ -114,7 +114,8 @@ pk_transaction_id_save_job_count (guint job_count)
gboolean
pk_transaction_id_equal (const gchar *tid1, const gchar *tid2)
{
return pk_strcmp_sections (tid1, tid2, 3, 2);
/* TODO, ignore the data part */
return pk_strequal (tid1, tid2);
}
/**
@ -124,23 +125,21 @@ gchar *
pk_transaction_id_generate (void)
{
gchar *rand_str;
gchar *job;
gchar *tid;
guint job_count;
/* load from file */
job_count = pk_transaction_id_load_job_count ();
rand_str = pk_transaction_id_get_random_hex_string (8);
job = g_strdup_printf ("%i", job_count++);
job_count++;
/* save the new value */
pk_transaction_id_save_job_count (job_count);
/* make the tid */
tid = g_strjoin (";", job, rand_str, "data", NULL);
tid = g_strdup_printf ("/%i_%s_data", job_count, rand_str);
g_free (rand_str);
g_free (job);
return tid;
}
@ -174,34 +173,7 @@ libst_transaction_id (LibSelfTest *test)
/************************************************************/
libst_title (test, "tid equal pass (same)");
ret = pk_transaction_id_equal ("34;1234def;r23", "34;1234def;r23");
if (ret) {
libst_success (test, NULL);
} else {
libst_failed (test, NULL);
}
/************************************************************/
libst_title (test, "tid equal pass (different)");
ret = pk_transaction_id_equal ("34;1234def;unknown", "34;1234def;r23");
if (ret) {
libst_success (test, NULL);
} else {
libst_failed (test, NULL);
}
/************************************************************/
libst_title (test, "tid equal fail 1");
ret = pk_transaction_id_equal ("34;1234def;r23", "35;1234def;r23");
if (ret) {
libst_success (test, NULL);
} else {
libst_failed (test, NULL);
}
/************************************************************/
libst_title (test, "tid equal fail 2");
ret = pk_transaction_id_equal ("34;1234def;r23", "34;1234dff;r23");
ret = pk_transaction_id_equal ("/34_1234def_r23", "/34_1234def_r23");
if (ret) {
libst_success (test, NULL);
} else {