Touch up the depends and requiredby display in package details

This started out as a validation fix for the W3 validator: we had some <ul/>
elements that ended up on that page with no inner <li/> elements, so it was
invalid markup. I then realized we don't need to call the methods multiple
times so use the 'with' template tag.

Signed-off-by: Dan McGee <dan@archlinux.org>
This commit is contained in:
Dan McGee 2010-01-31 16:43:48 -06:00
parent 382d36f4bf
commit 48ee2c28a2

View File

@ -60,10 +60,12 @@ <h2 class="title">{{ pkg.pkgname }} {{ pkg.pkgver }}-{{ pkg.pkgrel }}</h2>
<table width="100%">
<tr>
<td valign="top" width="50%">
{% with pkg.get_depends as deps %}
<div class="listing">
<h4>Dependencies ({{pkg.get_depends|length}}):</h4>
<h4>Dependencies ({{deps|length}}):</h4>
{% if deps %}
<ul style="font-size:small;list-style:none">
{% for depend in pkg.get_depends %}
{% for depend in deps %}
{% ifequal depend.pkg None %}
<li>{{ depend.dep.depname }} (virtual)</li>
{% else %}
@ -71,17 +73,23 @@ <h4>Dependencies ({{pkg.get_depends|length}}):</h4>
{% endifequal %}
{% endfor %}
</ul>
{% endif %}
</div>
{% endwith %}
</td>
<td valign="top">
{% with pkg.get_requiredby as rqdby %}
<div class="listing">
<h4>Required By ({{pkg.get_requiredby|length}}):</h4>
<h4>Required By ({{rqdby|length}}):</h4>
{% if rqdby %}
<ul style="font-size:small;list-style:none">
{% for req in pkg.get_requiredby %}
{% for req in rqdby %}
<li><a href="{{req.get_absolute_url}}">{{ req.pkgname }}{% ifequal req.repo.name "Testing" %} (testing){% endifequal %}{% ifequal req.repo.name "Unstable" %} (unstable){% endifequal %}</a></li>
{% endfor %}
</ul>
{% endif %}
</div>
{% endwith %}
</td>
</tr>
</table>