V4L/DVB: videobuf-dma-sg: Avoid using a wrong size
drivers/media/video/videobuf-dma-sg.c: In function ‘__videobuf_mmap_mapper’: drivers/media/video/videobuf-dma-sg.c:557: warning: ‘size’ may be used uninitialized in this function The condition where size is floating should never happen, due to the paranoia check, but a future change at the logic might break it. So, let's just set size to zero and use it for the paranoia check. Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
e4dac289f0
commit
474675ad80
@ -554,7 +554,7 @@ static int __videobuf_mmap_mapper(struct videobuf_queue *q,
|
|||||||
{
|
{
|
||||||
struct videobuf_dma_sg_memory *mem = buf->priv;
|
struct videobuf_dma_sg_memory *mem = buf->priv;
|
||||||
struct videobuf_mapping *map;
|
struct videobuf_mapping *map;
|
||||||
unsigned int first, last, size, i;
|
unsigned int first, last, size = 0, i;
|
||||||
int retval;
|
int retval;
|
||||||
|
|
||||||
retval = -EINVAL;
|
retval = -EINVAL;
|
||||||
@ -579,7 +579,7 @@ static int __videobuf_mmap_mapper(struct videobuf_queue *q,
|
|||||||
}
|
}
|
||||||
|
|
||||||
/* paranoia, should never happen since buf is always valid. */
|
/* paranoia, should never happen since buf is always valid. */
|
||||||
if (VIDEO_MAX_FRAME == first) {
|
if (!size) {
|
||||||
dprintk(1, "mmap app bug: offset invalid [offset=0x%lx]\n",
|
dprintk(1, "mmap app bug: offset invalid [offset=0x%lx]\n",
|
||||||
(vma->vm_pgoff << PAGE_SHIFT));
|
(vma->vm_pgoff << PAGE_SHIFT));
|
||||||
goto done;
|
goto done;
|
||||||
|
Loading…
Reference in New Issue
Block a user