PWN-Hunter/android_kernel_xiaomi_sdm845
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf tools: Improve message about missing symtabs for deleted DSOs

Browse Source 
Instead of:

  no symbols found in /usr/lib/gstreamer-0.10/libgsttypefindfunctions.so (deleted), maybe install a debug package?
  no symbols found in /usr/lib/gstreamer-0.10/libgstaudioconvert.so (deleted), maybe install a debug package?

We now emit:

  /usr/lib/gstreamer-0.10/libgsttypefindfunctions.so was updated, restart the long running apps that use it!
  /usr/lib/gstreamer-0.10/libgstaudioconvert.so was updated, restart the long running apps that use it!

Which is far less misleading about what the cause of the
symbol mismatch is.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1256927305-4628-3-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Arnaldo Carvalho de Melo 2009-10-30 16:28:25 -02:00 committed by Ingo Molnar
parent 00a192b395
commit d70a5402f9
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tools/perf/util/map.c
View File

@ -75,6 +75,8 @@ struct map *map__new(struct mmap_event *event, char *cwd, int cwdlen)
return NULL; return NULL;
} }
#define DSO__DELETED "(deleted)"
struct symbol * struct symbol *
map__find_symbol(struct map *self, u64 ip, symbol_filter_t filter) map__find_symbol(struct map *self, u64 ip, symbol_filter_t filter)
{ {
@ -86,8 +88,18 @@ map__find_symbol(struct map *self, u64 ip, symbol_filter_t filter)
self->dso->long_name); self->dso->long_name);
return NULL; return NULL;
} else if (nr == 0) { } else if (nr == 0) {
pr_warning("No symbols found in %s, maybe install a debug package?\n", const char *name = self->dso->long_name;
self->dso->long_name); const size_t len = strlen(name);
const size_t real_len = len - sizeof(DSO__DELETED);
if (len > sizeof(DSO__DELETED) &&
strcmp(name + real_len + 1, DSO__DELETED) == 0)
pr_warning("%.*s was updated, restart the "
"long running apps that use it!\n",
real_len, name);
else
pr_warning("no symbols found in %s, maybe "
"install a debug package?\n", name);
return NULL; return NULL;
} }
} }