19d337dff9
This patch completely rewrites the rfkill core to address the following deficiencies: * all rfkill drivers need to implement polling where necessary rather than having one central implementation * updating the rfkill state cannot be done from arbitrary contexts, forcing drivers to use schedule_work and requiring lots of code * rfkill drivers need to keep track of soft/hard blocked internally -- the core should do this * the rfkill API has many unexpected quirks, for example being asymmetric wrt. alloc/free and register/unregister * rfkill can call back into a driver from within a function the driver called -- this is prone to deadlocks and generally should be avoided * rfkill-input pointlessly is a separate module * drivers need to #ifdef rfkill functions (unless they want to depend on or select RFKILL) -- rfkill should provide inlines that do nothing if it isn't compiled in * the rfkill structure is not opaque -- drivers need to initialise it correctly (lots of sanity checking code required) -- instead force drivers to pass the right variables to rfkill_alloc() * the documentation is hard to read because it always assumes the reader is completely clueless and contains way TOO MANY CAPS * the rfkill code needlessly uses a lot of locks and atomic operations in locked sections * fix LED trigger to actually change the LED when the radio state changes -- this wasn't done before Tested-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br> [thinkpad] Signed-off-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: John W. Linville <linville@tuxdriver.com>
56 lines
1.3 KiB
C
56 lines
1.3 KiB
C
#ifndef B43legacy_RFKILL_H_
|
|
#define B43legacy_RFKILL_H_
|
|
|
|
struct b43legacy_wldev;
|
|
|
|
#ifdef CONFIG_B43LEGACY_RFKILL
|
|
|
|
#include <linux/rfkill.h>
|
|
|
|
|
|
|
|
struct b43legacy_rfkill {
|
|
/* The RFKILL subsystem data structure */
|
|
struct rfkill *rfkill;
|
|
/* Did initialization succeed? Used for freeing. */
|
|
bool registered;
|
|
/* The unique name of this rfkill switch */
|
|
char name[sizeof("b43legacy-phy4294967295")];
|
|
};
|
|
|
|
/* The init function returns void, because we are not interested
|
|
* in failing the b43 init process when rfkill init failed. */
|
|
void b43legacy_rfkill_init(struct b43legacy_wldev *dev);
|
|
void b43legacy_rfkill_exit(struct b43legacy_wldev *dev);
|
|
|
|
const char *b43legacy_rfkill_led_name(struct b43legacy_wldev *dev);
|
|
|
|
|
|
#else /* CONFIG_B43LEGACY_RFKILL */
|
|
/* No RFKILL support. */
|
|
|
|
struct b43legacy_rfkill {
|
|
/* empty */
|
|
};
|
|
|
|
static inline void b43legacy_rfkill_alloc(struct b43legacy_wldev *dev)
|
|
{
|
|
}
|
|
static inline void b43legacy_rfkill_free(struct b43legacy_wldev *dev)
|
|
{
|
|
}
|
|
static inline void b43legacy_rfkill_init(struct b43legacy_wldev *dev)
|
|
{
|
|
}
|
|
static inline void b43legacy_rfkill_exit(struct b43legacy_wldev *dev)
|
|
{
|
|
}
|
|
static inline char *b43legacy_rfkill_led_name(struct b43legacy_wldev *dev)
|
|
{
|
|
return NULL;
|
|
}
|
|
|
|
#endif /* CONFIG_B43LEGACY_RFKILL */
|
|
|
|
#endif /* B43legacy_RFKILL_H_ */
|