fc0138fa0c
[ Upstream commit 942859d969de7f6f7f2659a79237a758b42782da ]
snprintf() should be given the full buffer size, not one less. And it
guarantees nul-termination, so doing it manually afterwards is
pointless.
It's even potentially harmful (though probably not in practice because
CPER_REC_LEN is 256), due to the "return how much would have been
written had the buffer been big enough" semantics. I.e., if the bank
and/or device strings are long enough that the "DIMM location ..."
output gets truncated, writing to msg[n] is a buffer overflow.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Fixes:
|
||
---|---|---|
.. | ||
libstub | ||
test | ||
arm-init.c | ||
arm-runtime.c | ||
capsule-loader.c | ||
capsule.c | ||
cper.c | ||
efi-pstore.c | ||
efi.c | ||
efibc.c | ||
efivars.c | ||
esrt.c | ||
fake_mem.c | ||
Kconfig | ||
Makefile | ||
memattr.c | ||
memmap.c | ||
reboot.c | ||
runtime-map.c | ||
runtime-wrappers.c | ||
vars.c |