PWN-Hunter/android_system_sepolicy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

checkseapp: check the size of key value pairs

Browse Source 
OOB write if the size of the key value pairs exceeds the max.

Test: Add a long line to the seapp_contexts file

Change-Id: Iaa3e697e7ac134eb6829b8b36b090997ca344b3a
Signed-off-by: liwugang <liwugang@xiaomi.com>
This commit is contained in:
liwugang 2018-11-15 20:13:15 +08:00 committed by Nick Kralevich
parent ea9cf8148e
commit eb74dd9f86
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/check_seapp.c
View File

@ -1128,6 +1128,9 @@ static void parse_file(file_info *in_file) {
if (!token)
break;
if (token_cnt == KVP_NUM_OF_RULES)
goto oob;
} /*End token parsing */
rule_map *r = rule_map_new(keys, token_cnt, lineno, in_file->name, is_never_allow);
@ -1148,6 +1151,10 @@ err:
oom:
log_error("In function %s: Out of memory\n", __FUNCTION__);
exit(EXIT_FAILURE);
oob:
log_error("Reading file: \"%s\" line: %zu reason: the size of key pairs exceeds the MAX(%zu)\n",
in_file->name, lineno, KVP_NUM_OF_RULES);
exit(EXIT_FAILURE);
}
/**