Evolinx/packagekit
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove a memory leak, and optimise the storage of the ident structure on sparse data

Browse Source
This commit is contained in:
Richard Hughes 2007-08-31 01:52:23 +01:00
parent 2078b94b52
commit 5476e9948a
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libpackagekit/pk-package-id.c
View File

@ -69,7 +69,6 @@ pk_package_id_split (const gchar *package_id)
}
/* name has to be valid */
sections = g_strsplit (package_id, ";", 0);
if (strlen (sections[0]) == 0) {
pk_warning ("Package ident package is empty");
goto out;
@ -117,10 +116,18 @@ pk_package_id_new_from_string (const gchar *package_id)
/* create new object */
ident = pk_package_id_new ();
if (strlen (sections[0]) > 0) {
ident->name = g_strdup (sections[0]);
}
if (strlen (sections[1]) > 0) {
ident->version = g_strdup (sections[1]);
}
if (strlen (sections[2]) > 0) {
ident->arch = g_strdup (sections[2]);
}
if (strlen (sections[3]) > 0) {
ident->data = g_strdup (sections[3]);
}
g_strfreev (sections);
return ident;
}