The following SELinux denials are seen when booting into charger mode:
type=1400 audit(1746.159:22): avc: denied { dac_read_search } for
comm="init.qcom.usb.s" capability=2 scontext=u:r:vendor_qti_init_shell:s0
tcontext=u:r:vendor_qti_init_shell:s0 tclass=capability permissive=0
type=1400 audit(1746.159:23): avc: denied { dac_override } for
comm="init.qcom.usb.s" capability=1 scontext=u:r:vendor_qti_init_shell:s0
tcontext=u:r:vendor_qti_init_shell:s0 tclass=capability permissive=0
type=1400 audit(1746.267:24): avc: denied { dac_read_search } for
comm="init.qcom.usb.s" capability=2 scontext=u:r:vendor_qti_init_shell:s0
tcontext=u:r:vendor_qti_init_shell:s0 tclass=capability permissive=0
type=1400 audit(1746.267:25): avc: denied { dac_override } for
comm="init.qcom.usb.s" capability=1 scontext=u:r:vendor_qti_init_shell:s0
tcontext=u:r:vendor_qti_init_shell:s0 tclass=capability permissive=0
The DAC errors indicate that there is some kind of access, usually
by root, to a file or directory where the ownership is given to another
user/group which is not root. So since root may not have explicit
permission to access it has to override the default access control
which is flagged by SELinux.
In charger mode, like in normal boot, the init.qcom.usb.sh script
executes in the same process as init, so it is executing as root.
The script is trying to read/write to the ConfigFS string entries.
The fix for these denials is to ensure that any files/directories
being accessed by the script give root permission to access the same.
Hence remove the shell/shell ownership change when creating the USB
gadget and config subdirectories in ConfigFS.
While at it also remove mounting of ADB FFS and the ConfigFS function
instance as we are not enabling ADB in charger mode.
Change-Id: I33d6a9ce8e1bb4594a053156d46688ab11c5491d
On some targets (such as GKI) the default bMaxPower is not able to be
hard-coded using the kernel config USB_GADGET_VBUS_DRAW. Instead we can
set this value via USB ConfigFS.
Change-Id: I467dab4fa85e7d07837f6afb6d58c73812619022
This change adds rules to move usage of USB MTP/PTP functionality
with USB F_FS driver instead of F_MTP/F_PTP drivers. It selects
functionfs based MTP/PTP functionality based on vendor.usb.use_ffs_mtp
property value. Set vendor.usb.use_ffs_mtp to true for Lahaina platform.
sys.usb.mtp.device_type is used by MTP server to provide perceived
device type information to host. Use correct sys.usb.mtp.device_type
property and set value 3 ( 2 - media player and 3 - Mobile handset).
Change-Id: I005bfea4babef012e331dcc4999e5e6af6465b6e
Remove obsolete android_usb based property triggers now
that configfs is always used. Merge in init.msm.configfs.rc
so we now have just a single .rc init file.
Also remove all other references to /sys/class/android_usb/*.
Change-Id: I06eba8e715ccee5974dc9de8ac19df6c79ae0c45
Directly execute the init.qcom.usb.sh helper in the 'on boot'
and 'on charger' actions rather than spawning it as a oneshot
service. After that, directly update sys.usb.config with the
from persist.vendor.usb.config. This streamlines and guarantees
it will execute synchronously which can help avoid rare race
conditions with other USB property triggers that could execute
in parallel.
Change-Id: Iaf798b146d071b11857a4cf54fbaf7ae0d5d2431
Create configFS entries for two additional diag instances
and mount their respective FunctionFS paths. The diag-router
app will read/write to these for MDM and WLAN instances,
respectively.
Change-Id: Icc896f19a76e7d154e5b9b9a2f1bfc422a3e47e3
With support now for diag-router using USB FFS driver, the kernel
driver is no longer going to automatically update the DLOAD IMEM
with the required PID/Serial information that is used when the device
transitions into crash download mode so that a port re-enumeration
is avoided. In order to pass the same PID/Serial information, the
same kernel driver now exposes configfs attributes that userspace
can write. Hence the serial number can be written once during "on
boot", and likewise the PID can be updated whenever a composition
is selected that contains Diag as the first interface.
Change-Id: I45d52ecd30fcc4978c9bb4fbe9caa75e12c0b860
Support Diag over USB using F_FS driver by instantiating "ffs.diag"
ConfigFS instance and mounting the functionfs path for the same.
Introduce a new property 'vendor.usb.diag.func.name' which is used
to distinguish between FFS and legacy f_diag and update all Diag-
enabled compositions accordingly.
The `vendor.usb.diag.func.name` property can be overridden on
a per-target basis simply by adding the key=value to the
PRODUCT_PROPERTY_OVERRIDES build variable. This gets generated
into the /vendor/build.prop which overrides the default value of
'diag' set in /vendor/default.prop.
Change-Id: I005a441b39697b489bcd8d74b5cb26fb3b47fdf7
Since Android 10 blobs are being used, org.codeaurora.ims still runs
as phone UID as seen by these denials:
m.android.phone: type=1400 audit(0.0:2914): avc: denied { read } for name="u:object_r:qcom_ims_prop:s0" dev="tmpfs" ino=13660 scontext=u:r:radio:s0 tcontext=u:object_r:qcom_ims_prop:s0 tclass=file permissive=0
m.android.phone: type=1400 audit(0.0:473): avc: denied { call } for scontext=u:r:radio:s0 tcontext=u:r:hal_imsrtp:s0 tclass=binder permissive=0
Change-Id: Ic8c1b7996b9e0e7b63ba2a153441c9e8467a8a31
This block is completely redundant because..
- WITH_DEXPREOPT := true is the default
- WITH_DEXPREOPT_PIC is never read
- DEX_PREOPT_DEFAULT := nostripping has no effect when the
BOARD_USES_SYSTEM_OTHER_ODEX flag is set to true
Test: make
Change-Id: I618a1e395ca1a14555cd50eef1a4f1aa079b553d
There is no evidence that Qualcomm devices running a rather recent IMS
stack need to include AOSP RCS packages. RCS already worked before this
change and continues to do so, but the main goal was to get rid of some
of the RCS related log spam, which was accomplished here.
Change-Id: I219546e29d288373877e9bcd194a60ef5e09f224
For whatever reason, Xiaomi left an empty path here for the use
case of "deep-buffer-playback bt-sco-wb". This leads to audio
stuttering and error log spam of:
D audio_hw_primary: enable_audio_route: apply mixer and update path: deep-buffer-playback bt-sco-wb
D audio_route: Apply path: deep-buffer-playback bt-sco-wb
D audio_hw_primary: select_devices: done
D audio_hw_primary: start_output_stream: Opening PCM device card_id(0) device_id(0) format(0x4)
E audio_hw_primary: pcm_open_prepare_helper: pcm_prepare returned -1
...under the following use case:
* join a voice call (whatsapp, discord, etc.)
* using BT headset
* then start a video playback with audio
Therefore, add the missing mixer path from CAF's sdm845 mixer config
to link it to "deep-buffer-playback bt-sco", so that the ctl of
"SLIMBUS_7_RX Audio Mixer MultiMedia1" can be used correctly.
"<ctl name="BT SampleRate" value="KHZ_16" />" entry has been omitted
because our mixer path from stock does not have BT SampleRate set
to KHZ_8 by default.
Signed-off-by: Chenyang Zhong <zhongcy95@gmail.com>
Change-Id: I94e8d7f714b80380f46148a3fdd8d140a99c6bb2
android.hardware.vr.high_performance.xml contains set of
features required for a VR-compatible device
Change-Id: Id3f8cdafc551077b682cb25a9316f20352aa3cdf
*) If you turn the screen on whilst the device is still in a pocket the
fp sensor stays disabled even when the device is moved out into the open.
*) This commit ensures that the FP sensor is always reenabled when the
screen is turned on.
Change-Id: If27967a468673f29d9c1a4742cc9dda95adaab59
Since composer HAL is now able to handle display brightness,
this can be removed from the lights HAL.
Change-Id: Ic10cead638382d448a94205bcec3543177d387f6
This change sets the new Vulkan dEQP level feature flag to the value
corresponding to the Vulkan dEQP tests for Android 11.
Change-Id: I0715787b310f48c27747849ebd0724e0ca6fbbde
Preinstalled overlays needn't be signed with the same cert
as the package it overlays, simply being preinstalled is
enough. Sign with the default cert instead for now, which
provides fewer special privileges.
Bug: 162195999
Test: verify values still overlaid correctly
Change-Id: I017491fd383551c5aadf8648edb900e0c12a27b8
Runtime Resource Overlays (RROs) can no longer change the value of
resources in manifest when read during PackagerParser.
This change uses component-override to enable the service by default.
Remove usages of profile_supported_* from overlays as they no
longer configure the enable state of Bluetooth componenets.
Bug: 135048762
Test:
adb shell pm query-services \
com.android.bluetooth/.avrcp.AvrcpTargetService
adb shell pm query-services \
com.android.bluetooth/.avrcpcontroller.AvrcpControllerService
adb shell pm query-services \
com.android.bluetooth/.ba.BATService
adb shell pm query-services \
com.android.bluetooth/.hid.HidDeviceService
adb shell pm query-services \
com.android.bluetooth/.hid.HidHostService
adb shell pm query-services \
com.android.bluetooth/.sap.SapService
Change-Id: I284d254a921b14d1533745611a083f4b5a27d9dc
Xiaomi changed something in V12.0.1.0 that causes invalid secure mode in DRM.
E SDM : DRMPlaneManager::Perform: Invalid secure mode 15967184 to set on plane 93
E SDM : DRMPlaneManager::Perform: Invalid plane id 112
E SDM : DRMAtomicReq::Validate: drmModeAtomicCommit failed with error 2
E SDM : HWDeviceDRM::Validate: failed with error -2 for Peripheral Display
Change-Id: I2a5aeaea45c0419582d89ccf168ab8a5373c4d0b
Signed-off-by: Chenyang Zhong <zhongcy95@gmail.com>
